Skip to content

ref(chat): remove per-Turn delivery choice - #1736

Merged
dcramer merged 1 commit into
mainfrom
codex/store-publish-on-turn
Aug 29, 2026
Merged

ref(chat): remove per-Turn delivery choice#1736
dcramer merged 1 commit into
mainfrom
codex/store-publish-on-turn

Conversation

@dcramer

@dcramer dcramer commented Aug 29, 2026

Copy link
Copy Markdown
Member

This removes the per-message and per-Turn delivery choice from the current
Inbound message, worker, Turn, and Run contracts. Slack input continues to
deliver to Slack. Web and local input stay in Junior. Resource events with a
Conversation Location deliver there. Scheduled tasks, Event tasks, and Plugin
dispatches keep delivery to their explicit Destination. Agent invocations stay
internal. Mailbox batches also stay within one Actor and Source.

Redis mailbox and Turn cursor records still write the legacy
publishExternally field for older deployed readers. Current workers ignore
it. Both writes have TODOs with the condition for removal.

Two temporary paths remain clear in the code. The shared web and Resource event
worker still checks Resource event Source before it supplies Slack Delivery
because it also stores the assistant Message. Slack dispatch still creates a
temporary Slack Message and Thread. Each path has a TODO with its exact removal
condition.

Refs #1563

@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
junior-docs Ready Ready Preview Aug 29, 2026 8:15am

Request Review

@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from e0928c0 to f0be9d2 Compare August 29, 2026 05:16
@dcramer dcramer changed the title ref(chat)!: store publish on mailbox input and Turns ref(chat)!: deliver from Conversation Location Aug 29, 2026
@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from f0be9d2 to fcd6fc7 Compare August 29, 2026 05:19
Comment thread packages/junior/src/chat/task-execution/conversation-turn.ts Outdated
@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from fcd6fc7 to 1968ba5 Compare August 29, 2026 06:15
@dcramer dcramer changed the title ref(chat)!: deliver from Conversation Location ref(chat)!: remove per-Turn publish choice Aug 29, 2026
@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from 1968ba5 to 7027551 Compare August 29, 2026 06:40

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7027551. Configure here.

Comment thread packages/junior/src/chat/task-execution/conversation-turn.ts
@dcramer
dcramer force-pushed the codex/store-publish-on-turn branch from 7027551 to 0f5b3ce Compare August 29, 2026 08:14
@dcramer dcramer changed the title ref(chat)!: remove per-Turn publish choice ref(chat): remove per-Turn delivery choice Aug 29, 2026
@dcramer
dcramer marked this pull request as ready for review August 29, 2026 17:14
@github-actions github-actions Bot added the risk: high PR risk score: high label Aug 29, 2026
@dcramer
dcramer merged commit c5b459d into main Aug 29, 2026
39 checks passed
@dcramer
dcramer deleted the codex/store-publish-on-turn branch August 29, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high PR risk score: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant